Skip to content

Close DIV generated for controller view #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 13, 2021
Merged

Close DIV generated for controller view #85

merged 2 commits into from
Nov 13, 2021

Conversation

binhly
Copy link
Contributor

@binhly binhly commented Oct 27, 2021

The generated view for the controller was missing a closing

binhly added 2 commits October 27, 2021 08:55
@binhly
Correctly close the div tag
3f1010e 
The div tag was missing a /
@binhly
Merge pull request #1 from binhly/binhly-close-div
e8e0e9b 
Correctly close the div tag
dixpac
dixpac reviewed Nov 7, 2021
View reviewed changes
Copy link
Contributor

@dixpac dixpac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 good catch

@dixpac
Copy link
Contributor

dixpac commented Nov 13, 2021

@dhh when you got some time can you merge this 😃

@dhh dhh merged commit 2c074f9 into rails:main Nov 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dixpac dixpac dixpac left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@binhly @dixpac @dhh